Back to Signal Feed
CodeTracked since May 20, 2026

Add role-based review setup schema as foundation for `entire review`

This PR lays the first-step foundation for role-based review configuration by adding `ReviewConfig.Role` and `fix_after_review` settings, plus a dedicated setup flow to collect and persist per-agent roles and review instructions.

ReviewConfig.Rolesettings.LoadMigrateLegacyRolesentire review setup

What Happened

  • This PR lays the first-step foundation for role-based review configuration by adding `ReviewConfig.Role` and `fix_after_review` settings, plus a dedicated setup flow to collect and persist per-agent roles and review instructions.
  • This PR lays the first-step foundation for role-based review configuration by adding `ReviewConfig.Role` and `fix_after_review` settings, plus a dedicated setup flow to collect and persist per-agent roles and review instructions.
  • 1 evidence item attached for review.

What is Different

Before

Scattered source updates, isolated context, and manual follow-up across multiple feeds.

Now

Adds concrete review-configuration primitives that separate reviewer vs fixer responsibilities in settings, with idempotent migration from the legacy field, a one-fixer validation rule at setup time, and a new interactive command to persist role maps.

Why Track This

Why It Matters

Operators and teams using `entire review` can now predefine who reviews and who fixes before running review commands, reducing role ambiguity and downstream configuration drift in team workflows. This is implemented through `Role`-based settings, migration helpers, and the new `entire review setup` flow; continue watching downstream consumers of `.entire/settings.json` for assumptions about the removed legacy field and whether follow-up PR #2 cutover correctly preserves these assumptions after the legacy picker is removed.

Impact

Operators and teams using `entire review` can now predefine who reviews and who fixes before running review commands, reducing role ambiguity and downstream configuration drift in team workflows. This is implemented through `Role`-based settings, migration helpers, and the new `entire review setup` flow; continue watching downstream consumers of `.entire/settings.json` for assumptions about the removed legacy field and whether follow-up PR #2 cutover correctly preserves these assumptions after the legacy picker is removed.

What To Watch Next

  • Watch whether ReviewConfig.Role becomes a repeated pattern.
  • Track follow-up changes around AI Code Review.
  • Compare future signals against this evidence trail.
  • Re-check risk flags: legacy_consumer_assumptions_on_review_fix_agent, migrate_roles_without_auto_persistence.
Open Topic TimelineOpen Technical EventOpen Original Sourcelegacy_consumer_assumptions_on_review_fix_agent / migrate_roles_without_auto_persistence / validation_dependency_on_setup_path / future_cutover_flow_incompatibility

Supporting Evidence

GITHUB PULL REQUESTHigh Trust

entireio/cli PR #1241: feat(review): role + setup foundation (PR 1 of 2)

A new `Role` enum (`Reviewer`/`Fixer`/`Both`/`Skip`) is introduced on `ReviewConfig`, and `settings.Load` runs idempotent `MigrateLegacyRoles` from legacy `review_fix_agent`.