Back to Signal Feed
CodeTracked since May 19, 2026

Fix permission skip flag data race with atomic.Bool

The PR changes `permissionService`’s `skip` flag from an unsynchronized `bool` to `sync/atomic.Bool`, and routes all accesses through `Load`/`Store`, removing a concurrent read/write race between `Request`/`SkipRequests` and `SetSkipRequests`.

permissionServiceskip flagsync/atomic.BoolLoad/Store

What Happened

  • The PR changes `permissionService`’s `skip` flag from an unsynchronized `bool` to `sync/atomic.Bool`, and routes all accesses through `Load`/`Store`, removing a concurrent read/write race between `Request`/`SkipRequests` and `SetSkipRequests`.
  • The PR changes `permissionService`’s `skip` flag from an unsynchronized `bool` to `sync/atomic.Bool`, and routes all accesses through `Load`/`Store`, removing a concurrent read/write race between `Request`/`SkipRequests` and `SetSkipRequests`.
  • 1 evidence item attached for review.

What is Different

Before

Scattered source updates, isolated context, and manual follow-up across multiple feeds.

Now

Implemented a minimal, scoped concurrency fix by replacing the plain `skip` field with `atomic.Bool` and updating all reads/writes to atomic operations; added a deterministic multithreaded regression test (`TestPermissionService_SkipRace`) that fails on the race before the fix and passes after it, demonstrating concrete behavior correctness under concurrent writes/reads.

Why Track This

Why It Matters

Operators and developers running concurrent permission checks will get more stable behavior and fewer misleading race failures during testing because the permission skip switch no longer races across goroutines, which reduces nondeterministic skip-path behavior and makes permission flow debugging more reliable. The patch is technically constrained to the `skip` field, so teams should still monitor CI race-detector coverage and inspect neighboring shared state (including other permission/service paths) for similar unsynchronized access patterns.

Impact

Operators and developers running concurrent permission checks will get more stable behavior and fewer misleading race failures during testing because the permission skip switch no longer races across goroutines, which reduces nondeterministic skip-path behavior and makes permission flow debugging more reliable. The patch is technically constrained to the `skip` field, so teams should still monitor CI race-detector coverage and inspect neighboring shared state (including other permission/service paths) for similar unsynchronized access patterns.

What To Watch Next

  • Watch whether permissionService becomes a repeated pattern.
  • Track follow-up changes around AI Debugging and Error Localization.
  • Compare future signals against this evidence trail.
  • Re-check risk flags: race_checks_only_cover_tested_code_paths, other_shared_state_in_permission_service_not_scoped.
Open Topic TimelineOpen Technical EventOpen Original Sourcerace_checks_only_cover_tested_code_paths / other_shared_state_in_permission_service_not_scoped / ci_must_keep_race_detector_enabled

Supporting Evidence

GITHUB PULL REQUESTHigh Trust

charmbracelet/crush PR #2957: fix(permission): use atomic.Bool for skip flag to fix data race

Concurrent goroutines previously raced on `permissionService.skip`; atomic access now makes this flag race-safe and CI verifies it with `go test -race`.